Form actions refresh plus paypal by Crabcyborg · Pull Request #3093 · Strategy11/formidable-forms

Crabcyborg · 2026-05-07T12:36:19Z

Closes https://github.com/Strategy11/formidable-pro/issues/6124

Requires https://github.com/Strategy11/formidable-pro/pull/6381/changes to work properly with multi-page forms.

Includes PayPal (originally #2678)
Include Form Actions refresh (originally #2999)

The PayPal update adds:

New PayPal global payment settings (with buttons to onboard like our Stripe and Square gateways).
New PayPal Commerce payment action.
Payment actions are now split into "Stripe", "Square", and "PayPal" actions. Payment action icons no longer exist unless the Authorize.Net add-on is active, since there is no icon for this gateway (and other possible custom gateways).
Many new payment settings specific to PayPal (Product Name, PayPal Button Settings, Customer syncing behaviour, Shipping address data).
Various UI changes for payment actions (the gateways radio buttons have been replaced by tab buttons and moved to the top of the action, the one time/recurring payment setting has been moved to the top of the action).

…ent values in the SDK url based on the actions

…e, hide the collect payment action as well, add another helper function for on form settings page

…dden for gateway settings, add pay later toggle

… add to comment, remove duplicate message

…t gateway details out of plugin and add a new filter

…nflict with Stripe

coderabbitai · 2026-05-07T12:36:30Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: feec280c-327f-4f8a-8e24-382fb71aee62

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch forms_actions_refresh_plus_paypal

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

Generate code and open pull requests
Plan features and break down work
Investigate incidents and troubleshoot customer tickets together
Automate recurring tasks and respond to alerts with triggers
Summarize progress and report instantly

Built for teams:

Shared memory across your entire org—no repeating context
Per-thread sandboxes to safely plan and execute work
Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

deepsource-io · 2026-05-07T12:37:47Z

DeepSource Code Review

We reviewed changes in 0144975...f1fd5e2 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

Code Review Summary

Analyzer	Status	Updated (UTC)	Details
PHP		May 7, 2026 12:36p.m.	Review ↗
JavaScript		May 7, 2026 12:36p.m.	Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

deepsource-io · 2026-05-07T12:37:59Z

DeepSource Code Review

We reviewed changes in e1563e4...541da16 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

Important

Some issues found as part of this review are outside of the diff in this pull request and aren't shown in the inline review comments due to GitHub's API limitations. You can see those issues on the DeepSource dashboard.

PR Report Card

Overall Grade	Security Reliability Complexity Hygiene

Code Review Summary

Analyzer	Status	Updated (UTC)	Details
PHP		May 8, 2026 5:34p.m.	Review ↗
JavaScript		May 8, 2026 5:34p.m.	Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

deepsource-io · 2026-05-07T12:38:03Z

+		 * @param string $type
+		 * @param array  $field
+		 */
+		if ( apply_filters( 'frm_show_normal_field_type', $this->normal_field, $this->type, $this->field ) ) {


Function apply_filters invoked with 4 parameters, 2 required

The function call is not valid, which will result in a fatal runtime error.

deepsource-io · 2026-05-07T12:38:03Z

 	die( 'You are not allowed to call this page directly.' );
 }

+$limit = $action_control->action_options['limit'];


Variable $action_control might not be defined

A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

deepsource-io · 2026-05-07T12:38:03Z


+$limit = $action_control->action_options['limit'];
+
+if ( 'paypal' === $action_control->id_base ) {


Variable $action_control might not be defined

A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

deepsource-io · 2026-05-07T12:38:03Z

+if ( class_exists( 'FrmPaymentAction' ) ) {
+	class FrmDefPayPalLegacyAction extends FrmPaymentAction {
+		public function __construct() {
+			parent::__construct();


FrmDefPayPalLegacyAction::__construct() calls parent::__construct() but FrmDefPayPalLegacyAction does not extend any class

Invalid call to a static method. This would lead to a run time error.

deepsource-io · 2026-05-07T12:38:03Z

+		public function __construct() {
+			parent::__construct();
+
+			$this->id_base = 'paypal-legacy';


Access to an undefined property FrmDefPayPalLegacyAction::$id_base

This issue is raised when an attempt is made to access an undefined property.
This may not have been intended, and it is advisable to give the code another look to make sure the property is defined in the scope it is used in.

deepsource-io · 2026-05-07T12:38:03Z

+		 * @param array $settings
+		 * @param int   $form_id
+		 */
+		return apply_filters( 'frm_paypal_style', $style, $settings, $form_id );


Function apply_filters invoked with 4 parameters, 2 required

The function call is not valid, which will result in a fatal runtime error.

deepsource-io · 2026-05-07T12:38:03Z

+		 * @param array   $style_for_js
+		 * @param WP_Post $form_action
+		 */
+		return apply_filters( 'frm_paypal_button_style', $style_for_js, $form_action );


Function apply_filters invoked with 3 parameters, 2 required

The function call is not valid, which will result in a fatal runtime error.

deepsource-io · 2026-05-07T12:38:03Z

+	 *
+	 * @return array Array of products with prices and quantities.
+	 */
+	private static function get_pricing_data_from_posted_values( $form_id ) {


`get_pricing_data_from_posted_values` has a cyclomatic complexity of 16 with "High" risk

A function with high cyclomatic complexity can be hard to understand and
maintain. Cyclomatic complexity is a software metric that measures the number of
independent paths through a function. A higher cyclomatic complexity indicates
that the function has more decision points and is more complex.

deepsource-io · 2026-05-07T12:38:04Z

+	 *
+	 * @return array
+	 */
+	private static function get_shipping_data_from_posted_values( $action ) {


`get_shipping_data_from_posted_values` has a cyclomatic complexity of 24 with "High" risk

A function with high cyclomatic complexity can be hard to understand and
maintain. Cyclomatic complexity is a software metric that measures the number of
independent paths through a function. A higher cyclomatic complexity indicates
that the function has more decision points and is more complex.

deepsource-io · 2026-05-07T12:38:04Z

+
+		// Flush all output.
+		ob_end_flush();
+		@ob_flush();


Errors should not be suppressed

Suppressing errors using an error control operator(@) is discouraged. Instead of ignoring the raised error, it should be fixed accordingly.

…lus_paypal

Crabcyborg added 30 commits February 3, 2026 10:21

Merge branch 'master' into paypal

53b3d36

Add comment

4e4fd04

Merge branch 'master' into paypal

b5216cc

Test data

f09c65e

Merge branch 'master' into paypal

7519c16

Merge branch 'master' into paypal

9dc10fe

Pull the client id from global vars and populate the currency and int…

5f29189

…ent values in the SDK url based on the actions

Remove irrelevant client ids

4c6474e

Use array for gateway to improve compatibility with payments submodul…

dfd8f00

…e, hide the collect payment action as well, add another helper function for on form settings page

Merge branch 'master' into paypal

c288ce2

Merge branch 'master' into paypal

23f2960

Check for onCancel and remove the spinner from button

4f1d094

Work on adding additional action settings

b4b0ee2

Merge branch 'master' into paypal

0887269

Merge branch 'master' into paypal

541f0ef

Merge branch 'master' into paypal

0f4a0c8

Merge branch 'master' into paypal

d7dacb3

Move product name to a new view, add a helper function to echo frm_hi…

4de0da4

…dden for gateway settings, add pay later toggle

Add setting to disable Pay Later

82a74d8

Re-use logic for removing credit card field errors

5c50f1a

Working on pay later messaging

f4ff77f

Merge branch 'master' into paypal

0040dd6

Add new button settings

d8596c3

Remove extra open div breaking html

be35b9b

Fix wrong value for no messaging option causing it to show automatic,…

40fc871

… add to comment, remove duplicate message

Add the other payment gateway buttons

332b616

Clean up

61f9239

Move render messages to a function

4a37737

Merge branch 'master' into paypal

696373a

Stop trying to change the message based on selected country, pull tes…

881d61b

…t gateway details out of plugin and add a new filter

Crabcyborg added 13 commits April 27, 2026 15:20

Add meta more consistently

d176d03

Include shipping info in paypal order data

432f350

Always use the production BN code

722b644

Add logic for pending payments

a949396

Log PayPal debug IDs

c531a97

Merge branch 'paypal' into forms_actions_refresh_plus_paypal

f85b34a

Fix possible issue with apple pay using $0 amount

3db1ea2

Add check for connection before making request to create order

6452b07

Working on improving error handling

47ce24e

Working on displaying debug IDs for errors, prevent layout setting co…

5c3d8a1

…nflict with Stripe

Error handling tweaks

e5beaaf

Merge branch 'paypal' into forms_actions_refresh_plus_paypal

45fa9f2

Merge branch 'master' into forms_actions_refresh_plus_paypal

f1fd5e2

deepsource-io Bot reviewed May 7, 2026

View reviewed changes

Crabcyborg added 8 commits May 7, 2026 09:58

Merge branch 'rock/form-actions-refresh' into forms_actions_refresh_p…

28ba254

…lus_paypal

Add more error handling logic

a560016

Fix mago issues

5f96b84

Fix mago issues

2eefb12

Improvements to how debug IDs with with refunds

66e762a

Improve error handling

af1bd56

Improve failed capture error handling

b240c27

Add form action descriptions for Stripe/Square actions

95eb4c4

Crabcyborg added run analysis run tests labels May 8, 2026

Crabcyborg added this to the 6.31 (Form Action Refresh, Form Listing Refresh) milestone May 8, 2026

Crabcyborg requested a review from garretlaxton May 8, 2026 12:51

Remove frm-inverse from all icons

541da16


		$limit = $action_control->action_options['limit'];

		if ( 'paypal' === $action_control->id_base ) {

Conversation

Crabcyborg commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

deepsource-io Bot commented May 7, 2026

DeepSource Code Review

Code Review Summary

Uh oh!

deepsource-io Bot commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DeepSource Code Review

PR Report Card

Code Review Summary

Uh oh!

deepsource-io Bot May 7, 2026

Choose a reason for hiding this comment

Function apply_filters invoked with 4 parameters, 2 required

Uh oh!

deepsource-io Bot May 7, 2026

Choose a reason for hiding this comment

Variable $action_control might not be defined

Uh oh!

deepsource-io Bot May 7, 2026

Choose a reason for hiding this comment

Variable $action_control might not be defined

Uh oh!

deepsource-io Bot May 7, 2026

Choose a reason for hiding this comment

FrmDefPayPalLegacyAction::__construct() calls parent::__construct() but FrmDefPayPalLegacyAction does not extend any class

Uh oh!

deepsource-io Bot May 7, 2026

Choose a reason for hiding this comment

Access to an undefined property FrmDefPayPalLegacyAction::$id_base

Uh oh!

deepsource-io Bot May 7, 2026

Choose a reason for hiding this comment

Function apply_filters invoked with 4 parameters, 2 required

Uh oh!

deepsource-io Bot May 7, 2026

Choose a reason for hiding this comment

Function apply_filters invoked with 3 parameters, 2 required

Uh oh!

deepsource-io Bot May 7, 2026

Choose a reason for hiding this comment

`get_pricing_data_from_posted_values` has a cyclomatic complexity of 16 with "High" risk

Uh oh!

deepsource-io Bot May 7, 2026

Choose a reason for hiding this comment

`get_shipping_data_from_posted_values` has a cyclomatic complexity of 24 with "High" risk

Uh oh!

deepsource-io Bot May 7, 2026

Choose a reason for hiding this comment

Errors should not be suppressed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Crabcyborg commented May 7, 2026 •

edited

Loading

coderabbitai Bot commented May 7, 2026 •

edited

Loading

deepsource-io Bot commented May 7, 2026 •

edited

Loading

FrmDefPayPalLegacyAction::construct() calls parent::construct() but FrmDefPayPalLegacyAction does not extend any class